Add hub for Dev Archipelago#2545
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/dev-archipelago-hub/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
Still need:
|
|
This doesn't address all the needs of the Dev Archipelago hub, but I wanted to open it up to review before it gets too big! |
| ## Optional dialogue passed to `TalkBehavior`. Used when | ||
| ## instantiating an elder in a scene that doesn't use the standard | ||
| ## eternal loom dialogue flow. | ||
| @export var dialogue: Resource | ||
|
|
There was a problem hiding this comment.
The 3 elders in Fray's End actually already have different dialogues: they are each an instance of a different scene, so we can just set the TalkBehavior node's dialogue directly in each one.
Though if there are many elders in the archipelago I can see why you want to avoid continuing that trend. I think it's fine to do this. I wish Godot had a built-in way to export specific properties of child nodes from the root of the owning scene!
| # SPDX-FileCopyrightText: The Threadbare Authors | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| ~ start | ||
| # TODO: Name is up for debate |
There was a problem hiding this comment.
Personally I love it. I laughed out loud when I got the joke.
| @onready var repel_timer: Timer = %RepelTimer | ||
| @onready var repel_timer_2: Timer = $Sheep2/PlayerRepel2/RepelTimer2 |
There was a problem hiding this comment.
I would suggest either consistently using % unique names, or using @exports. But...
|
|
||
| ## Called when the node enters the scene tree for the first time. | ||
| func _ready() -> void: | ||
| if repel_timer_2.is_node_ready(): |
There was a problem hiding this comment.
...this is guaranteed by the scene structure. A node becomes ready after all its children are ready. But...
| await get_tree().create_timer(.5).timeout | ||
| repel_timer.start() |
There was a problem hiding this comment.
Since the other two timers are nodes in the scene, I would personally structure this with a third timer, with autostart set to True, timeout set to 0.5, oneshot set to true, and connect its timeout to start on RepelTimer. I think that makes the whole setup more consistent: it's all done in the scene tree.
| % Basics Elder: The people of Threadbare are counting on you. Your understanding of our world is necessary for its survival! | ||
| else: | ||
| % Basics Elder: Excellent choice, your training will surely help with your world-saving efforts. | ||
| % Basics Elder: Ah, those! Capable of such inginuity. To do what? I can't quite remember... |
There was a problem hiding this comment.
| % Basics Elder: Ah, those! Capable of such inginuity. To do what? I can't quite remember... | |
| % Basics Elder: Ah, those! Capable of such ingenuity. To do what? I can't quite remember... |
| if hook_control_1.state == 1: | ||
| hook_control_1.state = 0 | ||
| if hook_control_2.state == 1: | ||
| hook_control_2.state = 0 |
There was a problem hiding this comment.
Could you not use HookControl.State.AIMING rather than 1 here?
| player_hook.remove_from_group("hook_listener") | ||
| player_hook_2.remove_from_group("hook_listener") | ||
| hook_control_1 = player_hook.find_child("HookControl") | ||
| hook_control_2 = player_hook_2.find_child("HookControl") | ||
| hook_control_1.state = 0 | ||
| hook_control_2.state = 0 |
There was a problem hiding this comment.
Interesting. That component really wasn't designed for non-interactive use! I think this is fine as a workaround but rather than the boilerplate "called when..." comments, I think it would be worth documenting here why these lines are needed (as below for the state).
|
|
||
| first_sheep.hooked(hookable_box.find_child("HookableArea"), true) | ||
|
|
||
| await get_tree().create_timer(max(randf() * MAX_DELAY, MIN_DELAY)).timeout |
There was a problem hiding this comment.
| await get_tree().create_timer(max(randf() * MAX_DELAY, MIN_DELAY)).timeout | |
| await get_tree().create_timer(randf_range(MIN_DELAY, MAX_DELAY)).timeout |
There was a problem hiding this comment.
I love how this scene is taking shape.
Some minor nitpicking about foam:
Red circle: as documented on https://github.com/endlessm/threadbare/wiki/TileMapLayers-and-TileSets#foam the fake perspective means that the top edge of a patch of grass raised "one level" above the water should not have foam.
Blue circle: if you look closely you can see the foam through the cliff, which is because there is no cliff underneath that patch of grass:
|
Feel free to fix the suggestions either in this PR before merging, or later. |
2 participants
This PR introduces a scene
dev_archipelago.tscn, which will eventually be connected to Fray's End. The scene consists of a few islands, some of which are themed to correspond with mechanics in the game. Each island will have its own elder and set of quests leading to test scenes, gyms, and other playable documentation. The bridge behind the initial spawn point teleports the player back tofrays_end.tscn.Resolves #2531